[U-Boot] [PATCH v1 9/9] ARM: Odroid XU3: Modify Odroid XU3 config to boot by default from SD card

[Lukasz Majewski]

On Tue, 31 Jul 2018 23:40:10 +0530
Anand Moon <linux.amoon at gmail.com> wrote:

> Hi Lukasz,
> 
> On 27 July 2018 at 15:26, Lukasz Majewski <lukma at denx.de> wrote:
> > On Fri, 27 Jul 2018 14:42:32 +0530
> > Anand Moon <linux.amoon at gmail.com> wrote:
> >  
> >> Hi Lukasz,
> >>
> >> On 27 July 2018 at 13:54, Lukasz Majewski <lukma at denx.de> wrote:  
> >> > On Fri, 27 Jul 2018 08:34:15 +0530
> >> > Anand Moon <linux.amoon at gmail.com> wrote:
> >> >  
> >> >> Hi Lukasz,
> >> >>
> >> >> On 26 July 2018 at 21:23, Lukasz Majewski <lukma at denx.de>
> >> >> wrote:  
> >> >> > Hi Anand,
> >> >> >  
> >> >> >> Hi Lukasz,
> >> >> >>
> >> >> >> On 26 July 2018 at 03:55, Lukasz Majewski <lukma at denx.de>
> >> >> >> wrote:  
> >> >> >> > This commit allows by default booting Odroid XU3 from the
> >> >> >> > SD card (when e.g. eMMC module is not present).
> >> >> >> >
> >> >> >> > Signed-off-by: Lukasz Majewski <lukma at denx.de>
> >> >> >> >
> >> >> >> > ---
> >> >> >> >
> >> >> >> >  include/configs/odroid_xu3.h | 7 +++++--
> >> >> >> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >> >> >> >
> >> >> >> > diff --git a/include/configs/odroid_xu3.h
> >> >> >> > b/include/configs/odroid_xu3.h index
> >> >> >> > f495f6219ba9..818a06515cb2 100644 ---
> >> >> >> > a/include/configs/odroid_xu3.h +++
> >> >> >> > b/include/configs/odroid_xu3.h @@ -94,6 +94,9 @@
> >> >> >> >  #undef CONFIG_SYS_BOARD
> >> >> >> >  #define CONFIG_SYS_BOARD       "odroid"
> >> >> >> >
> >> >> >> > +#undef CONFIG_SYS_MMC_ENV_DEV
> >> >> >> > +#define CONFIG_SYS_MMC_ENV_DEV         2
> >> >> >> > +
> >> >> >> >  /* Define new extra env settings, including DFU settings
> >> >> >> > */ #undef CONFIG_EXTRA_ENV_SETTINGS
> >> >> >> >  #define CONFIG_EXTRA_ENV_SETTINGS \
> >> >> >> > @@ -105,8 +108,8 @@
> >> >> >> >         "console=" CONFIG_DEFAULT_CONSOLE "\0"\
> >> >> >> >         "fdtfile=exynos5422-odroidxu3.dtb\0" \
> >> >> >> >         "boardname=odroidxu3\0" \
> >> >> >> > -       "mmcbootdev=0\0" \
> >> >> >> > -       "mmcrootdev=0\0" \
> >> >> >> > +       "mmcbootdev=2\0" \
> >> >> >> > +       "mmcrootdev=1\0" \
> >> >> >> >         "mmcbootpart=1\0" \
> >> >> >> >         "mmcrootpart=2\0" \
> >> >> >> >         "dfu_alt_system="CONFIG_DFU_ALT_SYSTEM \
> >> >> >> > --
> >> >> >> > 2.11.0
> >> >> >> >  
> >> >> >>
> >> >> >> This changes probably breaks the booting from eMMC on
> >> >> >> Odroid-XU4  
> >> >> >
> >> >> > I suppose, that XU4 is also equipped with SD card slot as XU3.
> >> >> >
> >> >> > Nonetheless, as I don't have eMMC card for mine XU3, the only
> >> >> > way to boot my device is SD card.
> >> >> >
> >> >> > If you believe that this may be a problem, then I can drop
> >> >> > this patch.
> >> >> >
> >> >> > Have you checked patches from 1-8?
> >> >> > Does it work for you? If yes, please send tested-by tag.
> >> >> >  
> >> >>
> >> >> Yes you probably need to drop this patch,
> >> >> I had some tough time recovering my eMMC back to flash new
> >> >> u-boot.
> >> >>
> >> >> I have tested my eMMC with default boot.scr its boot good.
> >> >> Need to modify the boot.scr to boot into SD card.  
> >> >
> >> > SD card has different layout than eMMC.
> >> >
> >> > Despite above - you just shall need to apply patch 9/9 to get the
> >> > board running from SD card.
> >> >  
> >>
> >> Actually SD card are easy to modify and tune with just adding
> >> setenv mmcrootdev  "1" to autoboot.cmd from sdcard.
> >>
> >> but with eMMC module it's bit difficult to make this work,  
> >
> > Ach.... Ok, I see
> >
> > The problem is when you have both attached - the eMMC and SD card.
> >
> > In that case I always thought that one shall boot from eMMC and the
> > SD card shall be used as an extra storage space.
> >
> > Also, please keep in mind that IIRC the ROM first tries to boot from
> > eMMC, so you need BL1, u-boot placed there if it is present.
> >  
> 
> Can we create a different board initialization file to fine tune the
> odroid xu3 platform.
> for example Odroid U3 has # board/samsung/odroid/odroid.c
> 

The idea was to use common board file (./board/samsung/common/board.c)
for all Exynos5 based boards.

The potential differences were supposed to be added via device tree.

> where we can initialize for Odroid XU3 platform boards with following
> features. board_clock_init
> board_gpio_init
> exynos_power_init
> board_usb_init

Above two can be achieved with driver model. Providing such functions
would be a step back from full XU3/XU4 conversion to DM.

> board_leds
> 
> Best Regards
> -Anand




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180801/1a3d650c/attachment.sig>