[U-Boot] [PATCH 3/3] Remove <inttypes.h> includes and PRI* usages in printf() entirely

Andy Shevchenko andy.shevchenko at gmail.com
Mon Aug 6 13:20:19 UTC 2018


On Mon, Aug 6, 2018 at 2:47 PM, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:

> The use of PRI* makes the code super-ugly.  You can simply use
> "l" for printing uintptr_t, "ll" for u64, and no modifier for u32.

This is not always the case. I dunno what exact usage of PRIx in
U-Boot, but this is correct way for some size-variable types.
So, if U-Boot is known of not using something like off_t, then we are fine.
In any case the commit message should better justify this part (PRIu64
is specified in standard).

-- 
With Best Regards,
Andy Shevchenko


More information about the U-Boot mailing list