[U-Boot] [PATCH] common: Increase LOGLEVEL back to 6

Tom Rini trini at konsulko.com
Mon Aug 6 18:52:42 UTC 2018


On Mon, Aug 06, 2018 at 05:13:44PM +0200, Stefan Roese wrote:

> Commit 6a3e65dea3e5 ("common: Drop LOGLEVEL to 4") reduced the loglevel
> resulting in pr_warn() messages fro e.g. UBI are not shown anymore. With
> this change back to 6, messages like this appear again:
> 
> nand: attempt to erase a bad/reserved block @6000000
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Tom Rini <trini at konsulko.com>
> ---
>  common/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 4d7215a360..678a108508 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -266,7 +266,7 @@ config IDENT_STRING
>  
>  config LOGLEVEL
>  	int "loglevel"
> -	default 4
> +	default 6
>  	range 0 8
>  	help
>  	  All Messages with a loglevel smaller than the console loglevel will

This is a huge size increase on boards that rely on the default.  And I
bet this causes some boards to no longer link.  That said, if boards
want more logging messages, such as warnings, they can increase it on
their own.  If you feel that whole SoCs would benefit from this, I have
no objection to default 6 if ... being added.  And if the example
message you gave is more than just a warning and should be seen more
often, perhaps it should be a higher level message?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180806/5758aec7/attachment.sig>


More information about the U-Boot mailing list