[U-Boot] [PATCH 4/4] cmd: mtd: Add info text to mtd erase subcommand
Stefan Roese
sr at denx.de
Tue Aug 7 05:08:42 UTC 2018
Hi Boris,
On 06.08.2018 22:41, Boris Brezillon wrote:
> On Mon, 6 Aug 2018 17:12:53 +0200
> Stefan Roese <sr at denx.de> wrote:
>
>> Adding this info helps seeing, what really is being erased - especially
>> if no arguments are passed for offset and size. Now this is the
>> output:
>>
>> => mtd erase spi-nand0
>> Erasing 0x00000000 ... 0x07ffffff (65536 page(s))
>> nand: attempt to erase a bad/reserved block @6000000
>> nand: attempt to erase a bad/reserved block @7fe0000
>>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>> Cc: Miquel Raynal <miquel.raynal at bootlin.com>
>> Cc: Boris Brezillon <boris.brezillon at bootlin.com>
>> Cc: Jagan Teki <jagan at openedev.com>
>> ---
>> cmd/mtd.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/cmd/mtd.c b/cmd/mtd.c
>> index 38a89736cf..6d27698d1e 100644
>> --- a/cmd/mtd.c
>> +++ b/cmd/mtd.c
>> @@ -355,6 +355,9 @@ static int do_mtd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>> return EINVAL;
>> }
>>
>> + printf("Erasing 0x%08llx ... 0x%08llx (%d page(s))\n",
>> + off, off + len - 1, mtd_len_to_pages(mtd, len));
>
> Just a detail, but we usually count things in eraseblocks (not pages)
> when erasing an MTD device (you can use mtd_div_by_eb(len, mtd) to do
> that).
Will do for v2.
Thanks,
Stefan
More information about the U-Boot
mailing list