[U-Boot] [PATCH v4 01/13] test: regmap: Increase size of syscon0 memory

Mario Six mario.six at gdsys.cc
Tue Aug 7 07:37:52 UTC 2018


Hi Anatolij,
On Mon, Aug 6, 2018 at 10:56 PM Anatolij Gustschin <agust at denx.de> wrote:
>
> Hi Mario,
>
> On Fri,  3 Aug 2018 10:01:06 +0200
> Mario Six mario.six at gdsys.cc wrote:
> ...
> > diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
> > index e941cea3e5c..47cc961890f 100644
> > --- a/arch/sandbox/dts/test.dts
> > +++ b/arch/sandbox/dts/test.dts
> > @@ -406,7 +406,7 @@
> >
> >       syscon at 0 {
> >               compatible = "sandbox,syscon0";
> > -             reg = <0x10 4>;
> > +             reg = <0x10 16>;
> >       };
>
> Shouldn't this patch also update the test?
>
> diff --git a/test/dm/regmap.c b/test/dm/regmap.c
> index 152b3a4b80..a8d7e6829e 100644
> --- a/test/dm/regmap.c
> +++ b/test/dm/regmap.c
> @@ -25,7 +25,7 @@ static int dm_test_regmap_base(struct unit_test_state *uts)
>         ut_assertok_ptr(map);
>         ut_asserteq(1, map->range_count);
>         ut_asserteq(0x10, map->ranges[0].start);
> -       ut_asserteq(4, map->ranges[0].size);
> +       ut_asserteq(16, map->ranges[0].size);
>         ut_asserteq(0x10, map_to_sysmem(regmap_get_range(map, 0)));
>
>         ut_assertok(uclass_get_device(UCLASS_SYSCON, 1, &dev));
>
> Otherwise I get test errors:
>
>   https://travis-ci.org/vdsao/u-boot-video/jobs/412722215
>
Indeed. I'll fix that in v6 as well. Thanks for catching that!

> --
> Anatolij
>
Best regards,
Mario


More information about the U-Boot mailing list