[U-Boot] [PATCH 01/11] imx: Add bootcmd to load and run UEFI from mmc

[Alexander Graf]

> Am 07.08.2018 um 12:16 schrieb Tom Rini <trini at konsulko.com>:
> 
>> On Tue, Aug 07, 2018 at 01:11:11PM +0200, Stefano Babic wrote:
>> Hi Henry,
>> 
>>> On 14/07/2018 02:11, Henry Beberman wrote:
>>> From: Henry Beberman <henry.beberman at microsoft.com>
>>> 
>>> This patch enables i.MX platforms to easily add a boot script to their
>>> U-Boot Proper environment to automatically load and execute an EFI
>>> firmware from the first FAT partition of an MMC device.
>>> 
>>> This is a portion of enabling the Windows 10 IoT Core boot path.
>>> 
>>> The go command is overridden when CONFIG_UEFI_BOOT is specified. This
>>> new go will perform a cache flush/disable, disable interrupts, then
>>> jump to the address where UEFI was loaded.
>>> 
>>> This patch adds two new Kconfig options:
>>> CONFIG_UEFI_BOOT: Selects the UEFI bootcmd and overrides go to flush
>>> caches and disable interrupts.
>>> CONFIG_UEFI_LOAD_ADDR: Specifies the load address for the UEFI image
>>> 
>>> Signed-off-by: Henry Beberman <henry.beberman at microsoft.com>
>>> Cc: Stefano Babic <sbabic at denx.de>
>>> Cc: Fabio Estevam <fabio.estevam at nxp.com>
>>> Cc: Tom Rini <trini at konsulko.com>
>>> ---
>>> arch/arm/mach-imx/Makefile    |  1 +
>>> arch/arm/mach-imx/boot.c      | 19 +++++++++++++++++++
>>> common/Kconfig                | 17 +++++++++++++++++
>>> include/config_uefi_bootcmd.h | 29 +++++++++++++++++++++++++++++
>>> 4 files changed, 66 insertions(+)
>>> create mode 100644 arch/arm/mach-imx/boot.c
>>> create mode 100644 include/config_uefi_bootcmd.h
>>> 
>> 
>> I am really missing why we need this specially for i.MX. There is
>> nothing special to i.MX, and if this command is necessary, we should put
>> it in common code.
>> 
>> Anyway, should we not try to merge it with the general support for UEFI
>> in U-Boot ? We have already a "bootefi" command (aarch64 and x86,
>> currently).
> 
> Agreed, this should be folded in with our existing UEFI support, thanks!

Yes, please just use distro boot. Bootefi (which distro boot calls) already supports running UEFI binaries for real even on armv7.


Alex