[U-Boot] [PATCH 2/2] tpm: sandbox: fix wrong assignment with a simplification

[Simon Glass]

On 5 August 2018 at 10:53, Miquel Raynal <miquel.raynal at bootlin.com> wrote:
> The recv variable in sandbox_tpm2_fill_buf() is a pointer on a pointer
> of a char array. It means accessing *recv is the char array pointer
> itself while **recv is the first character of that array. There is no
> need for such indirection here, so simplify the code.
>
> Simplifying things will make the last assignment right: "*recv = NULL"
> is now correct. The issue has been found by the following Coverity
> Scan report:
>
>     CID 183371:  Incorrect expression  (UNUSED_VALUE)
>     Assigning value "4UL" to "*recv" here, but that stored value is overwritten before it can be used.
>     232             *recv += sizeof(rc);
>     233
>     234             /* Add trailing \0 */
>     235             *recv = NULL;
>
> While at simplifying things, use '\0' instead of NULL when adding an
> empty char at the end of the buffer.
>
> Reported-by: Tom Rini <trini at konsulko.com>
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> ---
>  drivers/tpm/tpm2_tis_sandbox.c | 52 +++++++++++++++++++++---------------------
>  1 file changed, 26 insertions(+), 26 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>