[U-Boot] [PATCH v1 14/17] cmd: fpga: Add support for missing fpga loadmk commands

Simon Glass sjg at chromium.org
Wed Aug 8 09:56:22 UTC 2018


Hi Michal,

On 3 August 2018 at 00:13, Michal Simek <michal.simek at xilinx.com> wrote:
> On 2.8.2018 22:37, Simon Glass wrote:
>> On 26 July 2018 at 08:16, Michal Simek <michal.simek at xilinx.com> wrote:
>>> Not all 4 fpga loadmk FIT image commands
>>
>> I don't understand this. Can you explain what you mean?
>
> hm not sure why I have written this short commit message.
> Maybe I wanted to extend it later when I was doing rebasing.
>
> Anyway let me explain.
>
> There are ways how to call fpga loadmk
>
> 1. Full command
> fpga loadmk [dev] [address]
>
> 2. Dev setup via variable
> set fpga [dev]
> fpga loadmk [address]
>
> 3. Address setup via variable
> set fpgadata [address]
> fpga loadmk [dev]
>
> 4. Dev and address setup via variables
> set fpga [dev]
> set fpgadata [address]
> fpga loadmk
>
> Before this patch only cases 1 and 3 were working but the part of code
> was trying to support also cases 2 and 4.
> That's why I have added all these use cases to pytest to make sure that
> all of them are working fine.

OK great, thanks. Can you please expand the commit message a little?

- Simon


More information about the U-Boot mailing list