[U-Boot] [PATCH] phy: Fix off-by-one error when parsing DT PHY bindings
Marek Vasut
marek.vasut at gmail.com
Thu Aug 9 07:24:50 UTC 2018
On 08/09/2018 09:04 AM, Patrice CHOTARD wrote:
> Hi Marek
>
> On 08/08/2018 02:34 PM, Marek Vasut wrote:
>> The code fails to copy the last PHY phandle argument, so it is
>> missing from the adjusted phandle args and the consumer cannot
>> use it to determine what the PHY should do.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
>> Cc: Patrice Chotard <patrice.chotard at st.com>
>> ---
>> drivers/phy/phy-uclass.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/phy-uclass.c b/drivers/phy/phy-uclass.c
>> index 6162395e75..a0ac30aa71 100644
>> --- a/drivers/phy/phy-uclass.c
>> +++ b/drivers/phy/phy-uclass.c
>> @@ -64,7 +64,7 @@ int generic_phy_get_by_index(struct udevice *dev, int index,
>> return ret;
>>
>> /* insert phy idx at first position into args array */
>> - for (i = args.args_count; i > 1 ; i--)
>> + for (i = args.args_count; i >= 1 ; i--)
>> args.args[i] = args.args[i - 1];
>>
>> args.args_count++;
>>
>
> Reviewed-by: Patrice Chotard <patrice.chotard at st.com>
Who's picking this up ?
--
Best regards,
Marek Vasut
More information about the U-Boot
mailing list