[U-Boot] sunxi: USB gadget does not work on H2+ after 92a30692b2b18f45aae6fdaae38d67ed03dd2d11

Nuno Gonçalves nunojpg at gmail.com
Mon Aug 13 10:29:21 UTC 2018


After this commit usb gadget does not work anymore for me on the Orange Pi
Zero (H2+).

Thanks,
Nuno

commit 92a30692b2b18f45aae6fdaae38d67ed03dd2d11
Author: Jagan Teki <jagan at amarulasolutions.com>
Date:   Fri Jul 20 12:34:20 2018 +0530

    phy: sun4i-usb: Call phy_passby even for PHY#0

    On newer Allwinner SoC, there is a pair of EHCI/OHCI USB hosts
    for OTG host mode. USB PHY passby must be configured for its
    corresponding PHY. so we can call for PHY#0. on the other hand
    in past usb-phy code the same thing can be restricted for
    Lower SoC's, other than H3/H5/A64.

    Now there is no need to restrict usb passby since the phy driver
    is DT enabled, and the respective phy calls will trigger based
    DT information initiated by the drivers.

    Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
    Tested-by: Jagan Teki <jagan at amarulasolutions.com>

diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c
b/drivers/phy/allwinner/phy-sun4i-usb.c
index 2b3cf48025..01f585a283 100644
--- a/drivers/phy/allwinner/phy-sun4i-usb.c
+++ b/drivers/phy/allwinner/phy-sun4i-usb.c
@@ -300,8 +300,7 @@ static int sun4i_usb_phy_init(struct phy *phy)
                                    data->cfg->disc_thresh,
PHY_DISCON_TH_LEN);
        }

-       if (usb_phy->id != 0)
-               sun4i_usb_phy_passby(phy, true);
+       sun4i_usb_phy_passby(phy, true);

        sun4i_usb_phy0_reroute(data, true);


More information about the U-Boot mailing list