[U-Boot] [PATCH] arm: dts: socfpga: stratix10: Move reset manager node to top

Ley Foon Tan lftan.linux at gmail.com
Wed Aug 15 10:37:38 UTC 2018


On Wed, Aug 15, 2018 at 6:31 PM, Marek Vasut <marex at denx.de> wrote:
> On 08/15/2018 12:28 PM, Ley Foon Tan wrote:
>> On Wed, Aug 15, 2018 at 6:13 PM, Marek Vasut <marex at denx.de> wrote:
>>> On 08/15/2018 08:01 PM, Ley Foon Tan wrote:
>>>> Move reset manager node to top, so reset driver can be load before
>>>> other drivers. Peripheral drivers have dependency on reset framework
>>>> to reset the hardware.
>>>>
>>>> Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com>
>>>
>>> This will break the next time you sync DTs with Linux, NAK.
>>> The reset manager should just load when it's needed by other drivers. If
>>> it doesn't work that way, something is seriously broken and that is what
>>> needs to be fixed.
>> Yes, seem that it doesn't load the reset manager driver automatically
>> when other driver depend on it.
>> Notice this issue when enable reset framework in GPIO, GPIO driver is
>> loaded at very beginning before go to command prompt.
>> Found this can work in SPL, but not in U-boot (load reset manager
>> driver automatically).
>
> That's probably because you're using the reset in .bind instead of
> .probe , as it should be used ? .bind is ONLY for binding the driver
> with the DM core.
>
Yes, you are right.
Will fix that.

Regards
Ley Foon


More information about the U-Boot mailing list