[U-Boot] [PATCH 4/7] common: avb_verify: Make local data static

Igor Opaniuk igor.opaniuk at linaro.org
Thu Aug 16 09:07:25 UTC 2018


Hi Eugeniu,
thanks for fixing this!

BTW, I plan to replace this workaround with hardcoded public RSA key
for verification of vbmeta image signature,
and an option to store it in RPMB using AVB TA/OP-TEE instead, just
after Jens's Wiklander patches (that he sent last Friday) are merged.

Reviewed-by: Igor Opaniuk <igor.opaniuk at linaro.org>

On 14 August 2018 at 03:43, Eugeniu Rosca <roscaeugeniu at gmail.com> wrote:
> Fix sparse complaint:
>
> common/avb_verify.c:14:21: warning: \
>   symbol 'avb_root_pub' was not declared. Should it be static?
>
> Signed-off-by: Eugeniu Rosca <erosca at de.adit-jv.com>
> ---
>  common/avb_verify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/avb_verify.c b/common/avb_verify.c
> index e6f3f207ff6f..9c90e1b4ae5c 100644
> --- a/common/avb_verify.c
> +++ b/common/avb_verify.c
> @@ -11,7 +11,7 @@
>  #include <malloc.h>
>  #include <part.h>
>
> -const unsigned char avb_root_pub[1032] = {
> +static const unsigned char avb_root_pub[1032] = {
>         0x0, 0x0, 0x10, 0x0, 0x55, 0xd9, 0x4, 0xad, 0xd8, 0x4,
>         0xaf, 0xe3, 0xd3, 0x84, 0x6c, 0x7e, 0xd, 0x89, 0x3d, 0xc2,
>         0x8c, 0xd3, 0x12, 0x55, 0xe9, 0x62, 0xc9, 0xf1, 0xf, 0x5e,
> --
> 2.18.0
>



-- 
Regards,
Igor Opaniuk


More information about the U-Boot mailing list