[U-Boot] [PATCH] configs: Migrate CONFIG_NR_DRAM_BANKS

Michal Simek monstr at monstr.eu
Fri Aug 17 06:17:45 UTC 2018


Hi Tom,

On 17.8.2018 03:12, Tom Rini wrote:
> We have the following cases:
> - CONFIG_NR_DRAM_BANKS was defined, migrate normally
> - CONFIG_NR_DRAM_BANKS_MAX was defined and then used for
>   CONFIG_NR_DRAM_BANKS after a check, just migrate it over now.
> - CONFIG_NR_DRAM_BANKS was very oddly defined on p2771-0000-* (to 1024 +
>   2), set this to 8.
> 
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---

zynq-common.h contained

#ifndef CONFIG_NR_DRAM_BANKS
# define CONFIG_NR_DRAM_BANKS          1
#endif

that's why I expect you wanted to use default setup which is 4.
We had this code there only for handling use case with additional bank
connected to programmable logic which is unused now.
Anyway will be the best to use 1 for all current zynq boards.

Also the similar thing happened with zynqmp boards where we had default
setup 2 and it was changed to 4.

#ifndef CONFIG_NR_DRAM_BANKS
# define CONFIG_NR_DRAM_BANKS          2
#endif

Code was there to handle mini configurations which use 1 bank all the time.

I checked microblaze and zynqmp-mini and zynqmp-r5 and they are fine.

Thanks,
Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180817/71853ffe/attachment.sig>


More information about the U-Boot mailing list