[U-Boot] [U-Boot, 1/4] env: fat: drop not needed #ifdef CMD_SAVEENV

Tom Rini trini at konsulko.com
Mon Aug 20 11:20:01 UTC 2018


On Tue, Aug 14, 2018 at 11:21:16AM +0200, Christian Gmeiner wrote:

> env_save_ptr(..) macro handles CMD_SAVEENV already.
> 
> Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> ---
>  env/fat.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/env/fat.c b/env/fat.c
> index 7f74c64dfe..165a11345f 100644
> --- a/env/fat.c
> +++ b/env/fat.c
> @@ -134,7 +134,5 @@ U_BOOT_ENV_LOCATION(fat) = {
>  #ifdef LOADENV
>  	.load		= env_fat_load,
>  #endif
> -#ifdef CMD_SAVEENV
>  	.save		= env_save_ptr(env_fat_save),
> -#endif

This series breaks a number of platforms (P1022DS_36BIT_NAND,
am43xx_hs_evm, mccmon6_nor to name just 3 out of many).  Please put v2
of this series through a world build (travis-ci is probably easiest).
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180820/2a26ba46/attachment.sig>


More information about the U-Boot mailing list