[U-Boot] [PATCH v3 27/58] fastboot: sunxi: Update fastboot mmc default device

[Maxime Ripard]

On Sun, Aug 19, 2018 at 07:26:44PM +0530, Jagan Teki wrote:
> Usually eMMC is default mmc device for fastboot.
> 
> By enabling DM_MMC, the mmc devices are probed as per
> DT status not with respect to MMC_SUNXI_SLOT_EXTRA in
> U-Boot proper.
> 
> Allwinner SoC has maximum of 4 mmc controllers start from
> mmc0...mmc3 on which mmc2 can be used an eMMC controller
> eventhough mmc3 some boards used as eMMC.
> 
> So, update the default fastboot device as 2 to make the
> standard usage irrespective of DT node status.
> 
> Other corner cases like different device usage, or specific
> mmc node status is not enabled in order in DTS must explicitly
> add config on the specific defconfig file.
> 
> Cc: Olliver Schinagl <oliver at schinagl.nl>
> Cc: Chen-Yu Tsai <wens at csie.org>
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>

This breaks all existing users, since if DM_MMC isn't set (and it
isn't at the moment), the MMC IDs won't change, and you're changing it
from either 0 or 1 to 2.

Can't we have a DT property instead? It looks much better than having
to deal with a non stable ID in Kconfig.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180820/c25950c0/attachment.sig>