[U-Boot] [PATCH v6 29/31] cmd: mtd: add 'mtd' command
Boris Brezillon
boris.brezillon at bootlin.com
Mon Aug 20 16:30:31 UTC 2018
On Mon, 20 Aug 2018 18:08:14 +0200
Miquel Raynal <miquel.raynal at bootlin.com> wrote:
> Hi Boris,
>
> Boris Brezillon <boris.brezillon at bootlin.com> wrote on Thu, 16 Aug 2018
> 18:22:03 +0200:
>
> > On Thu, 16 Aug 2018 17:30:27 +0200
> > Miquel Raynal <miquel.raynal at bootlin.com> wrote:
> >
> > > There should not be a 'nand' command, a 'sf' command and certainly not
> > > a new 'spi-nand' command. Write a 'mtd' command instead to manage all
> > > MTD devices/partitions at once. This should be the preferred way to
> > > access any MTD device.
> > >
> > > Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> > > Acked-by: Jagan Teki <jagan at openedev.com>
> >
> > [...]
> >
> > >
> > > +config CMD_MTD
> > > + bool "mtd"
> > > + depends on CMD_MTDPARTS
> >
> > Shouldn't we select it instead?
>
> No need anymore, I will entirely re-write the functions that are needed
> to have stateless clean MTD functions taking the best out of the MTD
> stack.
>
> All of them will be in mtd-uclass.c, declared in include/mtd.h.
Hm, I would have put those functions in mtdpart.c, but, as long as
mtd-uclass.c is compiled even if CONFIG_DM is not enabled I'm fine with
that.
More information about the U-Boot
mailing list