[U-Boot] [PATCH] efi_loader: Rename sections to allow for implicit data

[Simon Glass]

Hi Tom,

On 23 August 2018 at 11:55, Tom Rini <trini at konsulko.com> wrote:
> On Thu, Aug 23, 2018 at 06:41:56PM +0200, Andreas Färber wrote:
>> Am 23.08.2018 um 18:31 schrieb Simon Glass:
>> > On 23 August 2018 at 07:58, Tom Rini <trini at konsulko.com> wrote:
>> >> OK, now I'm trying to see what we need to do next.  Regardless of Alex's
>> >> current EFI PR, we have 7e21fbca26d1 ("efi_loader: Rename sections to
>> >> allow for implicit data") in master.  Looking at the PR, I see that it
>> >> does turn on -fdata-sections on x86, and that Bin reviewed/tested it.
>> >> So I'm going to push the PR there shortly.
>> >>
>> >> If, for sandbox you want to backout --gc-sections now (the commit
>> >> message does spell out that we need -ffunction/data-sections and what
>> >> for) and re-introduce that for the next release please post the patches
>> >> and I'll grab the backout one and apply it (or post it then PR it if
>> >> you'd rather, that's fine too).
>> >
>> > I'd like to back out all of the compilel/link flag changes:
>> >
>> > Here is my patch:
>> >
>> > http://patchwork.ozlabs.org/patch/954875/
>>
>> If you go down that path, please align the subject of that commit with
>> what it does, e.g., s/Revert/Partially revert/. Otherwise it is terribly
>> confusing for users that don't care about sandbox.

Yes I agree, sorry. I did a full revert and then changed it because I
figured the only real problem I had was with sandbox.

>
> With a slight subject reword, should I grab this patch now then?

That's fine with me.

Regards,
Simon