[U-Boot] [PATCH 2/8] arm: K3: Add support for AM654 SoC definition

[Tom Rini]

On Fri, Aug 24, 2018 at 08:28:17PM +0530, Lokesh Vutla wrote:
> 
> 
> On Friday 24 August 2018 07:41 PM, Tom Rini wrote:
> > On Tue, Aug 21, 2018 at 08:00:49PM +0530, Lokesh Vutla wrote:
> > 
> >> The AM654 device is designed for industrial automation and PLC
> >> controller class platforms among other applications. Introduce
> >> base support for AM654 SoC.
> > [snip]
> >> +config NON_SECURE_MSRAM_SIZE
> >> +	hex "Size of the MCU OC-MSRAM"
> >> +	default 0x80000
> >> +	help
> >> +	  Describes the total size of the MCU MSRAM. This doesn't
> >> +	  specify the total size of SPL as ROM can use some part
> >> +	  of this RAM. Once ROM gives control to SPL then this
> >> +	  complete size can be usable.
> >> +
> >> +config MAX_DOWNLODABLE_IMAGE_SIZE
> >> +	hex "Maximum size of the image"
> >> +	default 0x58000
> >> +	help
> >> +	  Describes the maximum size of the image that ROM can download
> >> +	  from any boot media.
> >> +
> >> +config MCU_SCRATCHPAD_BASE
> >> +	hex "Base address of Scratchpad RAM"
> >> +	default 0x40280000 if SOC_K3_AM6
> >> +	help
> >> +	  Describes the base address of MCU Scratchpad RAM.
> >> +
> >> +config MCU_SCRATCHPAD_SIZE
> >> +	hex "Size of Scratchpad RAM"
> >> +	default 0x200 if SOC_K3_AM6
> >> +	help
> >> +	  Describes the size of MCU Scratchpad RAM.
> > 
> > These are very generic names.  And are these really things that can be
> > configured and changed by the user?  MAX_DOWNLODABLE_IMAGE_SIZE is
> 
> You are right. These are not configurable by user, but changes from SoC
> to SoC within K3 family. Will fix it in v2 by dropping the prompt string.
> 

Well, the names are also fairly generic.  Why not just #define
SYS_K3_xxx ?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180824/e87acc42/attachment.sig>