[U-Boot] [PATCH] driver: net: fsl-mc: Memset MC reserve red memory before usage

Prabhakar Kushwaha prabhakar.kushwaha at nxp.com
Sat Aug 25 00:53:13 UTC 2018


Thanks York,

> -----Original Message-----
> From: York Sun
> Sent: Friday, August 24, 2018 8:24 PM
> To: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; u-
> boot at lists.denx.de
> Cc: joe.hershberger at ni.com; Ashish Kumar <ashish.kumar at nxp.com>;
> cristian.sovaiala at nxp.co
> Subject: Re: [PATCH] driver: net: fsl-mc: Memset MC reserve red memory before
> usage
> 
> On 08/23/2018 08:13 PM, Prabhakar Kushwaha wrote:
> > Hi York
> >
> >> -----Original Message-----
> >> From: York Sun
> >> Sent: Thursday, August 23, 2018 8:41 PM
> >> To: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; u-
> >> boot at lists.denx.de
> >> Cc: joe.hershberger at ni.com; Ashish Kumar <ashish.kumar at nxp.com>;
> >> cristian.sovaiala at nxp.co
> >> Subject: Re: [PATCH] driver: net: fsl-mc: Memset MC reserve red
> >> memory before usage
> >>
> >> On 08/15/2018 11:49 PM, Prabhakar Kushwaha wrote:
> >>> It is not necessary for MC memory to be always clean. It may have
> >>> garbage value causing indeterministic behavior during MC
> >>> initialization and run.
> >>>
> >>> So memset memory reserved for MC before any usage.
> >>
> >> Your commit message seems wrong. If it is not necessary to be clean,
> >> why it causes problems? I guess you mean the memory needs to be clean.
> >>
> >
> > Yes. You are right.
> > Commit message should be memory needs to be clean before passing to
> management complex.
> >
> > May I send v2 version for the same.
> >
> 
> You can either send v2 patch. Or if you don't have other update, I can fix the
> commit message when merging.
> 

I will send v2 of this patch as I recently found one issue after applying this patch.

--pk



More information about the U-Boot mailing list