[U-Boot] [PATCH V2 1/2] pci: Support parsing PCI controller DT subnodes

Alexander Graf agraf at suse.de
Wed Aug 29 21:56:26 UTC 2018



On 29.08.18 19:07, Marek Vasut wrote:
> On 08/29/2018 05:15 PM, Bin Meng wrote:
>> +Simon
>>
>> Hi Marek,
>>
>> On Wed, Aug 29, 2018 at 10:22 PM Marek Vasut <marek.vasut at gmail.com> wrote:
>>>
>>> On 08/24/2018 08:27 PM, Marek Vasut wrote:
>>>> The PCI controller can have DT subnodes describing extra properties
>>>> of particular PCI devices, ie. a PHY attached to an EHCI controller
>>>> on a PCI bus. This patch parses those DT subnodes and assigns a node
>>>> to the PCI device instance, so that the driver can extract details
>>>> from that node and ie. configure the PHY using the PHY subsystem.
>>>>
>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
>>>> Cc: Simon Glass <sjg at chromium.org>
>>>> Cc: Tom Rini <trini at konsulko.com>
>>>
>>> Well, bump ?
>>>
>>> This is the only missing patch to get my hardware working properly.
>>
>> I don't think we ever had an agreement on the v1 patch. Simon had a
>> long email that pointed out what Linux does seems like a 'fallback' to
>> find a node with no compatible string.
>>
>> Back to this, if we have to go with this way, please create a test
>> case to cover this scenario.
> 
> The fact that it works on a particular board is not tested enough?
> Do we need a custom, special, synthetic test ?

I agree that we should include test coverage for this case in some
automated fashion, so that nobody breaks support for it by accident.

What's the easiest way to get us there?

> Anyway, any feedback on the patch ? Did you test it ? I again only see
> "do this random stuff and that random stuff" , but zero actual feedback.

I think "potention" is a typo in your patch. Apart from that the logic
feels very sound to me though. It's perfectly valid in DT to refer to
subdevices by reg only.


Alex


More information about the U-Boot mailing list