[U-Boot] add default-option to bootmenu

[Frank Wunderlich]

thank you

as a small improvement (i've recently experienced), menu->active should be checked against menu->count (at the end of bootmenu_create), else it can be "outside" of the menu and selection is not visible till menu->active is below menu->count.

http://git.denx.de/?p=u-boot.git;a=blob;f=cmd/bootmenu.c;h=979ac4a638df48b9552feb82dd80ddbe74e69b8e;hb=f7bb20a53e829ce0b4d3c22c704e80b490d24016#l353

but i'm not 100% sure, how to handle it correctly, so i post it for discussion

because menu->active is initialized with 0 my preferred version is this:

if (menu->active >= menu->count)
  menu->active=0; //or any other value below menu->count (maybe a const set by boardconfig, but this can also be outside the menu, so 0 is imho better)

this is a user-configured environment-var so it is not a big problem :) but a simple check avoids this issue

regards Frank

> Gesendet: Dienstag, 27. November 2018 um 19:47 Uhr
> Von: "Tom Rini" <trini at konsulko.com>
> An: "Frank Wunderlich" <FrankWu at gmx.de>
> Cc: u-boot at lists.denx.de
> Betreff: Re: [U-Boot] add default-option to bootmenu
>
> On Fri, Oct 05, 2018 at 11:58:39AM +0200, Frank Wunderlich wrote:
> 
> > >From 6304b2ee2d2e9be47672d3559fee8d879b7328ff Mon Sep 17 00:00:00 2001
> > From: Frank Wunderlich <frank-w at public-files.de>
> > Date: Fri, 5 Oct 2018 11:41:59 +0200
> > Subject: [PATCH] add default-option to bootmenu
> > with this patch the selected Entry in bootmenu can be set by
> > environment-var bootmenu_default=<number>
> > Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
> 
> Applied to u-boot/master, thanks!
> 
> -- 
> Tom
>