[U-Boot] [PATCH] cmd: bmp: manage centered display

Patrick DELAUNAY patrick.delaunay at st.com
Mon Dec 3 08:45:57 UTC 2018


Hi Anatolij,

> From: Anatolij Gustschin <agust at denx.de>
> Sent: samedi 1 décembre 2018 15:06
> 
> Hi Patrick,
> 
> On Wed, 14 Nov 2018 10:18:22 +0100
> Patrick Delaunay patrick.delaunay at st.com wrote:
> ...
> >
> > +#define BMP_ALIGN_CENTER	0x7FFF
> 
> this already exists when including splash.h, I dropped it in v2.

Ok, I don't see that splash.h is included in cmd/bmp.c.

In fact I hesitate to move this define in commun bmp include (in include/lcd.h with bmp_display prototype for exmaple) 
to avoid a other double definition:

common/lcd.c:392 #define BMP_ALIGN_CENTER	0x7FFF
drivers/video/video_bmp.c:143:#define BMP_ALIGN_CENTER	0x7fff
include/splash.h:78:#define BMP_ALIGN_CENTER	0x7FFF

> --
> Anatolij


More information about the U-Boot mailing list