[U-Boot] [RESEND][PATCH] power: regulator: denied disable on always-on regulator

Felix Brack fb at ltec.ch
Mon Dec 3 11:07:17 UTC 2018


On 15.11.2018 13:45, Patrice Chotard wrote:
> From: Patrick Delaunay <patrick.delaunay at st.com>
> 
> Don't disable regulator which are tagged as "regulator-always-on" in DT.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Jack Mitchell <jack at embed.me.uk>
> Tested-by: Jack Mitchell <jack at embed.me.uk>
> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
> ---
> 
>  drivers/power/regulator/regulator-uclass.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c
> index 4da8e43259fc..4511625ff251 100644
> --- a/drivers/power/regulator/regulator-uclass.c
> +++ b/drivers/power/regulator/regulator-uclass.c
> @@ -106,10 +106,15 @@ int regulator_get_enable(struct udevice *dev)
>  int regulator_set_enable(struct udevice *dev, bool enable)
>  {
>  	const struct dm_regulator_ops *ops = dev_get_driver_ops(dev);
> +	struct dm_regulator_uclass_platdata *uc_pdata;
>  
>  	if (!ops || !ops->set_enable)
>  		return -ENOSYS;
>  
> +	uc_pdata = dev_get_uclass_platdata(dev);
> +	if (!enable && uc_pdata->always_on)
> +		return -EACCES;
> +
>  	return ops->set_enable(dev, enable);
>  }
>  
> 
This patch has been around since May 2018 (albeit superseded). A request
from Patrice Chotard to Jaehoon Chung about the patch status change
never got answered. Looking Patchwork I don't see any post from Jaehoon
after May 8. 2018.
Please don't get me wrong: I just want to make sure this patch doesn't
get forgotten, knowing very well, that it was posted (resent) just 2
weeks ago. Expecting quite a few board maintainers to enable DM_MMC in
the coming weeks and months this patch might get important to more
people as it prevents powering off the MMC supply voltage during power
cycling.
If the patch is on someones radar that's fine with me.

regards, Felix


More information about the U-Boot mailing list