[U-Boot] [PATCH v3 1/7] dm: serial: Add ->getconfig() callback
Andy Shevchenko
andriy.shevchenko at linux.intel.com
Mon Dec 3 16:18:31 UTC 2018
On Tue, Nov 27, 2018 at 06:02:54PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 26, 2018 at 06:02:28PM -0700, Simon Glass wrote:
> > On Tue, 20 Nov 2018 at 14:52, Andy Shevchenko
> > <andriy.shevchenko at linux.intel.com> wrote:
> > >
> > > In some cases it would be good to know the settings, such as parity,
> > > of current serial console. One example might be an ACPI SPCR table
> > > to generate using these parameters.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > > ---
> > > drivers/serial/sandbox.c | 13 +++++++++++++
> > > drivers/serial/serial-uclass.c | 16 ++++++++++++++++
> > > include/common.h | 1 +
> > > include/serial.h | 26 +++++++++++++++++++++++---
> > > test/dm/serial.c | 7 +++++++
> > > 5 files changed, 60 insertions(+), 3 deletions(-)
> > >
> >
> > My only concern is that serial_get_config() should have a device parameter.
>
> It's obviously out of scope of this series.
>
> The rest of similar functions are operate on top of current console device and
> do not have such parameter, while being DM-based functions.
>
> I would gladly rebase my series on top any work which is done regard above request.
> For now, I don't see such possibility.
So, time passed w/o a single action to this.
Is the feature undesirable? I would easily stop doing it, it consumes valuable time.
--
With Best Regards,
Andy Shevchenko
More information about the U-Boot
mailing list