[U-Boot] [PATCH 0/2] cmd: auto-complete args starting with a $

[Wolfgang Denk]

Dear Boris,

In message <20181204113313.577178ac at bbrezillon> you wrote:
>
> > But is this not based on the code of mtd_name_complete() which is
> > only availabole when MTD is present?
>
> Nope. See patch 1, the code is completely independent from the mtd cmd.

OK, then I misread the patches.

> Apart from the "make that available to everyone" comment, is there
> anything else you think should be changed? IOW, what is not compliant
> with a standard shell auto-completion in my proposal?

I can't say easily from the code.  I'd have to see this running (in
the sandbox, for example).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The greatest warriors are the ones who fight for peace."
- Holly Near