[U-Boot] [PATCH v4] pico-imx7d: Increase the CONFIG_ENV_OFFSET size

[Wolfgang Denk]

Dear Fabio,

In message <CAOMZO5AC--JreCuyWA2+Kudwcp1UPaMpynkWzAKfinGhUtzhvw at mail.gmail.com> you wrote:
>
> 1. The imx check has been introduced by:
>
> commit 43e6f94cbcaf193aeedcf86e85a3ff4c79f66773
> Author: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> Date:   Fri Nov 9 15:31:17 2018 +0100
>
>     imx: mkimage: add size check to the u-boot.imx make target
>
>     The make macro to check if the binary exceeds the board size limit is
>     taken straight from the root Makefile.
>
>     Without this and e.g. enabled EFI Vybrid fails booting as the regular
>     size limit check does not take the final u-boot.imx binary size into
>     account which is bigger due to alignment as well as IMX header stuff.

OK, so this is an additional (second) test run for a special
configuration, but the code to perform the test has just been
duplicated from the top level makefile (which is not a nice thing).

I think we should tun this code either into a Makefile function that
is defined only once and can then be used elsewhere as well, or
turn it into an external script unter scripts/

What do you think?

> 2. For testing purpose, I removed the imx check and patched the main
> Makefile, but still got error:
> u-boot-nodtb.bin exceeds file size limit:
>   limit:  0 bytes
>   actual: 482968 bytes
>   excess: 482968 bytes

What is your exact build target / command sequence to get here?

The "limit:  0 bytes" clearly indicates that the definition of
CONFIG_BOARD_SIZE_LIMIT is not known to Make at this point, or
wrong.

In the meantime, having the patch applied both to the TL Makefile
and to the imx one should work at least as good as the previous
code.

> How should we proceed?

If I know how to repeat your exact test, I can try to fix that.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
PoB = "Prisoner of Bill" -- those held captive, unwillingly or other-
wise, by the contemptible Microsoft monopoly.
         -- Tom Christiansen in <6abo45$3lc$2 at csnews.cs.colorado.edu>