[U-Boot] [PATCH v3 1/7] dm: serial: Add ->getconfig() callback

[Simon Glass]

Hi Andy,

On Wed, 5 Dec 2018 at 07:01, Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> On Wed, Dec 05, 2018 at 05:55:37AM -0700, Simon Glass wrote:
> > On Tue, 27 Nov 2018 at 09:03, Andy Shevchenko
> > <andriy.shevchenko at linux.intel.com> wrote:
> > > On Mon, Nov 26, 2018 at 06:02:28PM -0700, Simon Glass wrote:
>
> > > The rest of similar functions are operate on top of current console device and
> > > do not have such parameter, while being DM-based functions.
> > >
> > > I would gladly rebase my series on top any work which is done regard above request.
> > > For now, I don't see such possibility.
> >
> > My point is that you are adding a new function which does not use
> > driver model properly. The serial_getconfig() function should have a
> > device parameter, and it should not support non-DM, since it is a new
> > feature.
>
> I understand that, OTOH I can repeat myself that this would be very
> inconsistent with preexisting set of the functions. In my opinion that must be
> fixed altogether either before or after, but at once.

I don't think we can do that until DM migration is complete. But
perhaps I am missing something.

>
> > I'm going to pick this up, absent any other issues, and see if I can
> > do a patch for it afterwards.
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Thank you for review, and sorry for being persuader, I have several big tasks
> to be accomplished before my vacation starts.

So, given all my effort here, am I invited? :-)

Regards,
Simon