[U-Boot] [PATCH 0/5] dm: serial: Fix up some serial API errors

[Simon Glass]

Hi Andy,

On Wed, 5 Dec 2018 at 14:26, Andy Shevchenko <andy.shevchenko at gmail.com> wrote:
>
> On Wed, Dec 5, 2018 at 9:54 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > New serial functions should use a device pointer as the first argument.
> > The old functions are only there for backwards compatibilty, and can be
> > adjusted soon.
> >
> > For now, adjust the new functions to work correctly.
> >
>
> Thanks!
> I'm not sure I would be able to test it, but you may use my
> Reviewed-by: Andy Shevchenko <andy.shevchenko at gmail.com>
>
> Couple of remarks:
> - I think it make sense to try for serial device only once in
> acpi_create_spcr() if I'm reading result correctly

I believe that is what I am doing. Can you please be more specific?

> - the setconfig() / getconfig() have both some staled comments, it
> seems you dropped only for one.

Again I am not sure where?

Regards,
Simon