[U-Boot] [PATCH 1/4] rockchip: rk3399-puma: Cleanup vdd_log node in puma DTSI.

Philipp Tomsich philipp.tomsich at theobroma-systems.com
Thu Dec 6 13:35:02 UTC 2018


Christoph,

> On 06.12.2018, at 12:25, Christoph Muellner <christoph.muellner at theobroma-systems.com> wrote:
> 
> * Eliminate non-standard entries (rockchip,pwm_id and
>   rockchip,pwm_voltage).
> * Define target voltage level for vdd-log to 950 mV.

Could  you provide the necessary background in the commit message to
assert that the non-standard entries are indeed not needed and why you
want to set the voltage to 950mV?

In other words: a bit of motivation for this change would be appreciated.

> Signed-off-by: Christoph Muellner <christoph.muellner at theobroma-systems.com>
> ---
> arch/arm/dts/rk3399-puma.dtsi | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi
> index 11ffcb71778..2cac16e2ce7 100644
> --- a/arch/arm/dts/rk3399-puma.dtsi
> +++ b/arch/arm/dts/rk3399-puma.dtsi
> @@ -180,10 +180,7 @@
> 		regulator-max-microvolt = <1400000>;
> 		regulator-always-on;
> 		regulator-boot-on;
> -
> -		/* for rockchip boot on */
> -		rockchip,pwm_id= <2>;
> -		rockchip,pwm_voltage = <1000000>;
> +		regulator-init-microvolt = <950000>;
> 	};
> };
> 
> -- 
> 2.11.0
> 



More information about the U-Boot mailing list