[U-Boot] New item at list end for backwards compatibility

Stefano Babic sbabic at denx.de
Sat Dec 8 16:26:49 UTC 2018


Hi Marek, Robert,

On 05/12/18 15:52, Marek Vasut wrote:
> From: Robert Berger <robert.berger at ReliableEmbeddedSystems.com>
> 
> Signed-off-by: Robert Berger <robert.berger at ReliableEmbeddedSystems.com>
> 
> I received this off-list from Robert, it's a bugfix to mkimage, where
> the IH_TYPE_ enumeration changed recently and broke backward mkimage
> backward compatibility.
> 

That's true - new image type must be always appended for compatible reason.

> Peng, can you respin the patch, test it and repost it ? Thanks

I am reviewing and applying Peng's - but Peng posted a patch for i.MX8M,
patch for i.MX8 was already applied.

If nobody complains, I fix this myself by applying Peng's i.MX8M (not
MX8) patch, I mean this one:

	http://patchwork.ozlabs.org/patch/1000376/

Note: this also breaks compatibility

Regards,
Stefano

> 
> ---
> diff --git a/include/image.h b/include/image.h
> index 031c355..866e9f1 100644
> --- a/include/image.h
> +++ b/include/image.h
> @@ -251,7 +251,6 @@ enum {
>         IH_TYPE_FLATDT,                 /* Binary Flat Device Tree Blob */
>         IH_TYPE_KWBIMAGE,               /* Kirkwood Boot Image          */
>         IH_TYPE_IMXIMAGE,               /* Freescale IMXBoot Image      */
> -       IH_TYPE_IMX8IMAGE,              /* Freescale IMX8Boot Image     */
>         IH_TYPE_UBLIMAGE,               /* Davinci UBL Image            */
>         IH_TYPE_OMAPIMAGE,              /* TI OMAP Config Header Image  */
>         IH_TYPE_AISIMAGE,               /* TI Davinci AIS Image         */
> @@ -278,6 +277,7 @@ enum {
>         IH_TYPE_PMMC,            /* TI Power Management Micro-Controller
> Firmware */
>         IH_TYPE_STM32IMAGE,             /* STMicroelectronics STM32 Image */
>         IH_TYPE_SOCFPGAIMAGE_V1,        /* Altera SOCFPGA A10 Preloader */
> +       IH_TYPE_IMX8IMAGE,              /* Freescale IMX8Boot Image     */
> 
>         IH_TYPE_COUNT,                  /* Number of image types */
>  };
> 

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list