[U-Boot] [PATCH 2/2] imx: bootaux: fix stack and pc assignment on 64-bit platforms

Stefano Babic sbabic at denx.de
Sat Dec 8 17:38:28 UTC 2018



On 14/11/18 17:55, Gary Bisson wrote:
> Using ulong is wrong as its size depends on the Host CPU architecture
> (32-bit vs. 64-bit) although the Cortex-M4 is always 32-bit.
> 
> Without this patch, the stack and PC are obviously wrong and it
> generates an abort when used on 64-bit processors such as the i.MX8MQ.
> 
> Signed-off-by: Gary Bisson <gary.bisson at boundarydevices.com>
> ---
>  arch/arm/mach-imx/imx_bootaux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/imx_bootaux.c b/arch/arm/mach-imx/imx_bootaux.c
> index a1ea5c13f1..3103001b7c 100644
> --- a/arch/arm/mach-imx/imx_bootaux.c
> +++ b/arch/arm/mach-imx/imx_bootaux.c
> @@ -17,8 +17,8 @@ int arch_auxiliary_core_up(u32 core_id, ulong boot_private_data)
>  	if (!boot_private_data)
>  		return -EINVAL;
>  
> -	stack = *(ulong *)boot_private_data;
> -	pc = *(ulong *)(boot_private_data + 4);
> +	stack = *(u32 *)boot_private_data;
> +	pc = *(u32 *)(boot_private_data + 4);
>  
>  	/* Set the stack and pc to M4 bootROM */
>  	writel(stack, M4_BOOTROM_BASE_ADDR);
> 


Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list