[U-Boot] [PATCH 1/2] net: designware: fix tx packet length

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Sun Dec 9 20:50:49 UTC 2018


Am 17.11.2018 um 17:02 schrieb Joe Hershberger:
> On Sat, Nov 17, 2018 at 3:25 AM Simon Goldschmidt
> <simon.k.r.goldschmidt at gmail.com> wrote:
>>
>> The designware driver has a bug in setting the tx length into the dma
>> descriptor: it always or's the length into the descriptor without
>> zeroing out the length mask before.
>>
>> This results in occasional packets being transmitted with a length
>> greater than they should be (trailer). Due to the nature of Ethernet
>> allowing such a trailer, most packets seem to be parsed fine by remote
>> hosts, which is probably why this hasn't been noticed.
>>
>> Fix this by correctly clearing the size mask before setting the new
>> length.
>>
>> Tested on socfpga gen5.
>>
>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> 
> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> 

Marek, this and 2/2 is a assigned to you in patchwork, will you push 
them or is it Joe's code as u-boot-net maintainer?

Thanks,
Simon


More information about the U-Boot mailing list