[U-Boot] [PATCH 0/6] Add support for MIPS Creator CI20
Ezequiel Garcia
ezequiel at collabora.com
Mon Dec 10 21:31:29 UTC 2018
On Mon, 2018-12-10 at 22:00 +0100, Andreas Färber wrote:
> Hi Ezequiel,
>
> Am 10.12.18 um 21:35 schrieb Ezequiel Garcia:
> > Please note that I've added Paul's SOB to all the patches
> > he authored, to make the authorship chain more clear.
>
> That's only permitted if Paul agreed to that beforehand - did he?
> Never add other people's Signed-off-by if their patches didn't have it!
>
Fair enough. Let's hope Paul is OK with this. I wasn't really comfortable
not having Paul's SOB, given he authored all the patches.
Paul, do we have green light?
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
>
> As far as the authorship chain goes, you re-did all my forward-porting,
> that I'm not being credited with Signed-off-by in MMC/SoC/defconfig
> patches or verbally anywhere?
>
Oh, sorry, but I haven't used anything from your work. This series
is entirely based on https://github.com/marex/u-boot-mips/tree/ci20-v2018.xx.
Basically, I've cherry-picked the commits that weren't already available
in upstream, adding my SOB to those patches that I've modified.
Like I mentioned in the cover letter, most of the work has been done
by Paul Burton and Marek, so they deserve all the credit.
I'm just cleaning and submitting.
> Also this is surely not a v1 patch! Marek had posted CI20 before, so
> this should be v2 (doesn't look like I posted mine as v2, it didn't
> fully build yet) and thus your next iteration should be v3 please.
>
Well, I couldn't find Marek's cover letter, and I've decided to start from scratch.
Two years have passed, we have a new try at getting this merged so I think
it deserves it's own set of integers.
> Further, it would be very helpful - given the history of this patchset -
> to indicate which toolchain and version you used for building this.
>
I've used gcc version 5.3.0 (Sourcery CodeBench Lite 2016.05-8),
installed via Buildroot. Wasn't really paying attention to the toolchain.
I'll test with a recent gcc and post the results.
Thanks,
Eze
More information about the U-Boot
mailing list