[U-Boot] [PATCH v4 1/6] common: command: Fix command auto-completion
Simon Glass
sjg at chromium.org
Tue Dec 11 01:04:20 UTC 2018
Hi Boris,
On Mon, 3 Dec 2018 at 14:54, Boris Brezillon
<boris.brezillon at bootlin.com> wrote:
>
> When auto-completing command arguments, the last argument is not
> necessarily the one we need to auto-complete. When the last character is
> a space, a tab or '\0' what we want instead is list all possible values,
> or if there's only one possible value, place this value on the command
> line instead of trying to suffix the last valid argument with missing
> chars.
>
> Signed-off-by: Boris Brezillon <boris.brezillon at bootlin.com>
> Reviewed-by: Tom Rini <trini at konsulko.com>
> ---
> Changes in v4:
> -None
>
> Changes in v3:
> - Add Tom's R-b
>
> Changes in v2:
> - None
> ---
> common/command.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
I wonder if you might be able to add a test for this into test/py/tests ?
It seems useful to ensure it doesn't break in future.
Regards,
Simon
More information about the U-Boot
mailing list