[U-Boot] [PATCH] test: hexdump: fix misplaced return

Simon Glass sjg at chromium.org
Tue Dec 11 01:07:13 UTC 2018


On Sun, 9 Dec 2018 at 13:53, Simon Goldschmidt
<simon.k.r.goldschmidt at gmail.com> wrote:
>
> Am 05.12.2018 um 13:55 schrieb Simon Glass:
> > On Tue, 4 Dec 2018 at 13:30, Simon Goldschmidt
> > <simon.k.r.goldschmidt at gmail.com> wrote:
> >>
> >> One of the hexdump tests in test/lib/hexdump.c returns right at the
> >> start of the function without testing anything.
> >>
> >> Fix this by moving the 'return 0;' statement to the end of the function.
> >>
> >> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> >> ---
> >>
> >>   test/lib/hexdump.c | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > That's one way to make a test pass.
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Is there a plan to make all tests under test/ run with 'make check'?
> Seems like this one is not included there?

Yes I agree, it needs to be added.

- Simon


More information about the U-Boot mailing list