[U-Boot] [PATCH 1/3] mx7: Do not call lcdif_power_down() in the SPL case

Peng Fan peng.fan at nxp.com
Wed Dec 12 01:47:12 UTC 2018



> -----Original Message-----
> From: Otavio Salvador [mailto:otavio at ossystems.com.br]
> Sent: 2018年12月12日 2:41
> To: U-Boot Mailing List <u-boot at lists.denx.de>
> Cc: Stefano Babic <sbabic at denx.de>; Fabio Estevam
> <fabio.estevam at nxp.com>; Marek Vasut <marex at denx.de>; Richard Hu
> <richard.hu at technexion.com>; John Weber <john.weber at technexion.com>;
> Fabio Estevam <festevam at gmail.com>; Otavio Salvador
> <otavio at ossystems.com.br>; Ye Li <ye.li at nxp.com>; Peng Fan
> <peng.fan at nxp.com>; Bryan O'Donoghue <bryan.odonoghue at linaro.org>;
> Albert Aribaud <albert.u.boot at aribaud.net>; Rui Miguel Silva
> <rui.silva at linaro.org>; Anson Huang <anson.huang at nxp.com>; dl-linux-imx
> <linux-imx at nxp.com>
> Subject: [PATCH 1/3] mx7: Do not call lcdif_power_down() in the SPL case
> 
> From: Fabio Estevam <festevam at gmail.com>
> 
> Like it was done on imx6 in commit 9236269de57d ("imx: mx6: Fix
> implementantion reset_misc")
> 
> Do not call lcdif_power_down() in the SPL case to fix the following build error:
> 
>   LD      spl/u-boot-spl
>   MKIMAGE u-boot.img
> arch/arm/mach-imx/built-in.o: In function `reset_misc':
> /home/fabio/ossystems/u-boot/arch/arm/mach-imx/mx7/soc.c:372:
> undefined reference to `lcdif_power_down'
> scripts/Makefile.spl:375: recipe for target 'spl/u-boot-spl' failed
> 
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> ---
> 
>  arch/arm/mach-imx/mx7/soc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/mx7/soc.c b/arch/arm/mach-imx/mx7/soc.c
> index 3f74f8a3ed..7cfdff0981 100644
> --- a/arch/arm/mach-imx/mx7/soc.c
> +++ b/arch/arm/mach-imx/mx7/soc.c
> @@ -368,8 +368,10 @@ void s_init(void)
> 
>  void reset_misc(void)
>  {
> +#ifndef CONFIG_SPL_BUILD
>  #ifdef CONFIG_VIDEO_MXS
>  	lcdif_power_down();
>  #endif
> +#endif
>  }
> 

Reviewed-by: Peng Fan <peng.fan at nxp.com>

> --
> 2.20.0



More information about the U-Boot mailing list