[U-Boot] [PATCH v2 06/20] riscv: ax25: Hide the ax25-specific Kconfig option

Rick Chen rickchen36 at gmail.com
Wed Dec 12 09:02:17 UTC 2018


Hi Bin

Bin Meng <bmeng.cn at gmail.com> 於 2018年12月11日 週二 下午3:17寫道:
>
> Hi Rick,
>
> On Tue, Dec 11, 2018 at 3:06 PM Rick Chen <rickchen36 at gmail.com> wrote:
> >
> > > > Subject: [PATCH v2 06/20] riscv: ax25: Hide the ax25-specific Kconfig option
> > > >
> > > > There is no need to expose RISCV_NDS to the Kconfig menu as it is an
> > > > ax25-specific option.
> > > >
> >
> > Hi Bin
> >
> > Can you explain why there is no need to expose RISCV_NDS here ?
> >
>
> This is specific to AX25, and there is no need to appear in the
> Kconfig menu when people are building U-Boot for some other RISC-V
> platforms. Also even if you select Y in the Kconfig menu for this
> option for platforms other than AX25, it just does not help since all
> its logic is within arch/riscv/cpu/ax25.
>

AX25 can not select RISCV_NDS by default, it may cause build fail problem.
I still prefer to enable it by make menuconfig.
Can you drop this patch ?

Thanks
Rick

> Regards,
> Bin


More information about the U-Boot mailing list