[U-Boot] [PATCH] net: explicitly assign errno to return code in case of network failure

Christian Gmeiner christian.gmeiner at gmail.com
Wed Dec 12 09:23:25 UTC 2018


Am Di., 27. Nov. 2018 um 21:06 Uhr schrieb Christian Gmeiner
<christian.gmeiner at gmail.com>:
>
> Am Mi., 21. Nov. 2018 um 15:57 Uhr schrieb Thomas RIENOESSL
> <thomas.rienoessl at bachmann.info>:
> >
> > When dealing with two ethernet ports and having "netretry" set
> > to "once", it could occur that the connection (e.g. an ARP
> > request) failed, hence the status of the netloop was
> > "NETLOOP_FAIL". Due to the setting of "netretry", the network
> > logic would then switch to the other network interface,
> > assigning "ret" with the return value of "net_start_again()".
> > If this call succeeded we would return 0 (i.e. success) to
> > the caller when in reality the network action failed.
> >
> > Change-Id: I58b935b0f6c7a300d1dd0058803f7d3c9455b0dc
> > Signed-off-by: Thomas RIENOESSL <thomas.rienoessl at bachmann.info>
>
> Looks good - Gerrit change id should be removed before pushing this
> patch.
>
> Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
>

ping

-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info


More information about the U-Boot mailing list