[U-Boot] [RFC PATCH] usb: composite: Fix max packet size for USB3.0

Bin Meng bmeng.cn at gmail.com
Wed Dec 12 12:58:56 UTC 2018


On Wed, Dec 12, 2018 at 8:54 PM Marek Vasut <marex at denx.de> wrote:
>
> On 12/12/2018 12:49 PM, Siva Durga Prasad Paladugu wrote:
> > For USB3.0 the max packetsize for GET_DESCRIPTOR should be

nits: USB 3.0, packet size

> > sent as exponent value for 2. This means for 512, max packet
> > size should be filled with 9(2^9=512). Also, fill the USB
> > version field with 3.0 if speed is negotiated to Superspeed.
> > This fixes the issue of DFU gadget download failure with
> > superspeed. With out this patch, the max packet size is

nits: Without

> > overflowed to zero as the bMaxPacketsize is of u8 and hence
> > host is not able to detect this device.
> >
> > Signed-off-by: Siva Durga Prasad Paladugu <siva.durga.paladugu at xilinx.com>
>
> CCing Bin, I'd like his AB/RB.
>
> > ---
> >  drivers/usb/gadget/composite.c | 17 +++++++++++++++--
> >  1 file changed, 15 insertions(+), 2 deletions(-)
> >

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Regards,
Bin


More information about the U-Boot mailing list