[U-Boot] [PATCH v2 0/6] Add support for MIPS Creator CI20

[Tom Rini]

On Wed, Dec 12, 2018 at 03:03:40PM -0300, Ezequiel Garcia wrote:
> Hi Daniel,
> 
> On Wed, 2018-12-12 at 18:27 +0100, Daniel Schwierzeck wrote:
> > Hi Ezequiel,
> > 
> > Am 12.12.18 um 14:58 schrieb Ezequiel Garcia:
> > > A new round.
> > > 
> > > For this new round:
> > > 
> > >  * Replaced infinite while loop with wait_for_bit.
> > >  * Added a MAINTAINERS file. If anyone wants to co-maintain this,
> > >    please let me know.
> > > 
> > > This is based on top of yesterday's master (ee168783ae8) and has
> > > been tested by SD-card booting both U-Boot and Linux. Booting
> > > Linux via TFTP was also tested.
> > > 
> > > Toolchain used to test:
> > > 
> > > $ mips-linux-gcc -v
> > > Using built-in specs.
> > > COLLECT_GCC=mips-linux-gcc
> > > COLLECT_LTO_WRAPPER=/home/zeta/.buildman-toolchains/gcc-7.3.0-nolibc/mips-linux/bin/../libexec/gcc/mips-linux/7.3.0/lto-wrapper
> > > Target: mips-linux
> > > Configured with: /home/arnd/git/gcc/configure --target=mips-linux --enable-targets=all --prefix=/opt/crosstool/gcc-7.3.0-nolibc/mips-linux --
> > > enable-languages=c --without-headers --disable-bootstrap --disable-nls --disable-threads --disable-shared --disable-libmudflap --disable-libssp --
> > > disable-libgomp --disable-decimal-float --disable-libquadmath --disable-libatomic --disable-libcc1 --disable-libmpx --enable-checking=release
> > > Thread model: single
> > > gcc version 7.3.0 (GCC) 
> > > 
> > > SPL size:
> > > 
> > > $ size spl/u-boot-spl
> > >    text	   data	    bss	    dec	    hex	filename
> > >    9252	    752	    736	  10740	   29f4	spl/u-boot-spl
> > > 
> > > I've pushed a branch to https://github.com/ezequielgarcia/u-boot/tree/ci20-v2
> > > and made sure travis passed.
> > > 
> > 
> > Thanks for working on this but the problem with the original patch
> > series was that it was not fully driver model compatible and that stuff
> > like watchdog, reset and pin-muxing was open-coded instead of using the
> > proper frameworks. As the ship is sailing towards having only driver
> > model and device tree in U-Boot proper, it doesn't make sense to accept
> > new SoC/boards with legacy code especially if there is no active
> > maintainer who would do the conversion work. And with the upcoming dead
> > lines for DM conversions, boards with legacy code will be removed when
> > not converted. This is also one of the reasons why the Ingenic SoC
> > support we already had in mainline was removed. And readding parts of
> > the removed code doesn't make sense either because the patch series is
> > based on that old Ingenic SoC code.
> > 
> 
> I have to say I disagree with all of this.
> 
> The open coded drivers are used in SPL, which most likely can't affort
> any DM. Or **if** it can't afford it, it's a separate question that
> needs research.

And this is a topic that keeps coming up, so I need to chime in again.
For SPL, we _have_to_ keep in mind the various boot ROM hard space
limits.  This means that we end up needing to allow for some level of
open-coded drivers used in limited cases like SPL and then a full / real
driver in full U-Boot.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181212/90494112/attachment.sig>