[U-Boot] [U-Boot, PATCHv3, 1/4] dm: MIGRATION: Add migration plan for DM_MMC

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Thu Dec 13 09:45:30 UTC 2018


Hi Tom,

On Tue, Dec 4, 2018 at 5:51 AM Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Nov 29, 2018 at 06:21:11PM -0500, Tom Rini wrote:
>
> > Given that at this point the MMC subsystem itself has been migrated
> > along with a number of subsystem drivers, formalize a deadline for
> > migration.
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> > Cc: Jaehoon Chung <jh80.chung at samsung.com>
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> > Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>
> Applied to u-boot/master, thanks!

I have finally found the time to test current mainline on all our
board configs and now I still get the warning "This board does not use
CONFIG_DM_MMC". Supposedly this is because I have CONFIG_BLK disabled
(because of size limitations: this U-Boot image runs from FPGA and
just configures the eMMC without loading files from it).

Would it make sense to change the test like this:

diff --git a/Makefile b/Makefile
index 0d11ff9797..41bde15b74 100644
--- a/Makefile
+++ b/Makefile
@@ -920,7 +920,7 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
        @echo "before sending patches to the mailing list."
        @echo "===================================================="
 endif
-ifeq ($(CONFIG_MMC),y)
+ifeq ($(CONFIG_MMC)$(CONFIG_BLK),yy)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
        @echo "===================== WARNING ======================"
        @echo "This board does not use CONFIG_DM_MMC. Please update"

Is it intentional that CONFIG_BLK needs to be enabled?

Regards,
Simon


More information about the U-Boot mailing list