[U-Boot] [PATCH v3] zynq-gem: Use appropriate cache flush/invalidate for RX and TX

Bin Meng bmeng.cn at gmail.com
Thu Dec 13 15:31:53 UTC 2018


On Thu, Dec 13, 2018 at 10:39 PM Stefan Theil
<stefan.theil at mixed-mode.de> wrote:
>
> The cache was only flushed before *transmitting* packets, but not

nits: but not invalidated

> when receiving them, leading to an issue where new packets were
> handed to the receive handler with old contents in cache. This
> only happens when a lot of packets are received without sending
> packages every now and then. Also flushing the receive buffers
> in the transmit function makes no sense and can be removed.
>
> Signed-off-by: Stefan Theil <stefan.theil at mixed-mode.de>
>
> ---
> Changes for v2:
>         - Use invalidate_dcache_range instead of
>           flush_dcache_range
> Changes for v3:
>         - Remove unnecessary flushing of all RX
>           buffers in zynq_gem_send
> ---
>  drivers/net/zynq_gem.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list