[U-Boot] [PATCH] evb_rk3399: revert CONFIG_SYS_MMC_ENV_DEV to 0

Philipp Tomsich philipp.tomsich at theobroma-systems.com
Thu Dec 13 21:59:19 UTC 2018


On 04.12.2018, at 12:00, Max Kellermann <max.kellermann at gmail.com> wrote:
> 
> This was changed to 1 in commit 0717dde057e, but a few months later,
> commit 5f9411af37b swapped the order of eMMC and SD card by assigning
> indexed aliases to `&sdhci` and `&sdmmc`.

If this is a straight revert, I’d appreciate it if the was marked as such by
creating the commit using a 'git revert’ and then adding additional background
to explain why the revert was done.

However, we have a bigger issue here: the original commit has been in the
tree since 2016 and I am reluctant to change such fundamental naming without
a rationale.  This is particularily in knowledge of the on-list discussion that we’ve
had with Kever recently regarding his request to change the search order for booting.

Could you explain why you think that this should be changed?

Thanks,
Philipp.


More information about the U-Boot mailing list