[U-Boot] [PATCH] net: remove duplicate definition of ETHADDR_WILDCARD

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Fri Dec 14 13:43:30 UTC 2018


On Fri, Dec 14, 2018 at 2:28 PM Tom Rini <trini at konsulko.com> wrote:
>
> On Fri, Dec 14, 2018 at 09:55:32AM +0100, Simon Goldschmidt wrote:
> > + Tom
> >
> >
> > On Sun, Dec 9, 2018 at 9:51 PM Simon Goldschmidt
> > <simon.k.r.goldschmidt at gmail.com> wrote:
> > >
> > > Am 22.11.2018 um 16:58 schrieb Simon Goldschmidt:
> > > > ETHADDR_WILDCARD is defined as the same value in both env_flags.h
> > > > and env_callback.h
> > > >
> > > > As env_callback.h includes env_flags.h, remove the duplicate definition
> > > > from env_callback.h
> > > >
> > > > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> > > > ---
> > > >
> > > >   include/env_callback.h | 2 --
> > > >   1 file changed, 2 deletions(-)
> > > >
> > > > diff --git a/include/env_callback.h b/include/env_callback.h
> > > > index 3c44ff574b..507a52e13c 100644
> > > > --- a/include/env_callback.h
> > > > +++ b/include/env_callback.h
> > > > @@ -32,10 +32,8 @@
> > > >
> > > >   #ifdef CONFIG_REGEX
> > > >   #define ENV_DOT_ESCAPE "\\"
> > > > -#define ETHADDR_WILDCARD "\\d?"
> > > >   #else
> > > >   #define ENV_DOT_ESCAPE
> > > > -#define ETHADDR_WILDCARD
> > > >   #endif
> > > >
> > > >   #ifdef CONFIG_CMD_DNS
> > > >
> > >
> > > Ping?
> >
> > I haven't gotten an answer to this for nearly one month. It's a small
> > change, can this go in for v2019.01 please?
>
> I'd filed this off to Joe to grab since it is indeed small and a
> clean-up.

Well, I haven't heard from Joe since about one months now, that's why
I added you...

Regards,
Simon


More information about the U-Boot mailing list