[U-Boot] [PATCH 03/16] spi: Add non DM version of SPI_MEM

Jagan Teki jagan at amarulasolutions.com
Fri Dec 14 13:59:40 UTC 2018


On Fri, Dec 14, 2018 at 4:26 PM Vignesh R <vigneshr at ti.com> wrote:
>
> Hi,
>
> On 14/12/18 3:32 PM, Jagan Teki wrote:
> > On Thu, Dec 13, 2018 at 2:19 PM Vignesh R <vigneshr at ti.com> wrote:
> >>
> >>
> >>
> >> On 13/12/18 1:55 AM, Jagan Teki wrote:
> >>> On Wed, Dec 12, 2018 at 11:08 PM Vignesh R <vigneshr at ti.com> wrote:
> >>>>
> >>>> Add non DM version of SPI_MEM to support easy migration to new SPI NOR
> >>>> framework. This can be removed once DM_SPI conversion is complete.
> >>>
> >>> Our intention to use new driver to follow dm, why we need to support
> >>> non-dm? any usecases?
> >>>
> >>
> >> As said by others, AFAICS, DM_SPI migration is not going to be complete
> >> anytime soon. There are many boards and configs that don't enable
> >> DM_SPI. I propose you add a patch to print _warning during build_ for
> >> boards that don't have DM_SPI enabled (like DM_MMC and DM_USB) targeting
> >> v2019.07 or v2019.04 as deadline for removal. At the deadline you can
> >> remove spi-mem-nodm.c along with all other non DM code in SPI core.
> >
> > I don't understand why DM_SPI migration came to this topic? It's a
> > separate thread/issue.
> >
>
>
> I respectfully disagree. If DM_SPI migration was complete then SPI_MEM
> would be available for use by all subsystem. This patch wouldn't have
> been needed.

I have given my comment if spi-mem handle only DM.

Okay, lets move your approach of having spi-mem-nondm.c


More information about the U-Boot mailing list