[U-Boot] [PATCH v2 08/11] samsung: Drop board_enable_audio_codec()

[Lukasz Majewski]

On Sun, 16 Dec 2018 19:36:35 -0700
Simon Glass <sjg at chromium.org> wrote:

> This function is not needed now since the audio codecs have been
> converted to proper drivers. The codec-enable GPIO is handled there.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> Changes in v2: None
> 
>  board/samsung/common/exynos5-dt.c | 29 -----------------------------
>  1 file changed, 29 deletions(-)
> 
> diff --git a/board/samsung/common/exynos5-dt.c
> b/board/samsung/common/exynos5-dt.c index c183965b92a..87eb381345d
> 100644 --- a/board/samsung/common/exynos5-dt.c
> +++ b/board/samsung/common/exynos5-dt.c
> @@ -34,37 +34,8 @@
>  
>  DECLARE_GLOBAL_DATA_PTR;
>  
> -static void board_enable_audio_codec(void)
> -{
> -	int node, ret;
> -	struct gpio_desc en_gpio;
> -
> -	node = fdtdec_next_compatible(gd->fdt_blob, 0,
> -		COMPAT_SAMSUNG_EXYNOS5_SOUND);
> -	if (node <= 0)
> -		return;
> -
> -	ret = gpio_request_by_name_nodev(offset_to_ofnode(node),
> -					 "codec-enable-gpio", 0,
> &en_gpio,
> -					 GPIOD_IS_OUT |
> GPIOD_IS_OUT_ACTIVE);
> -	if (ret == -FDT_ERR_NOTFOUND)
> -		return;
> -
> -	/* Turn on the GPIO which connects to the codec's "enable"
> line. */
> -	gpio_set_pull(gpio_get_number(&en_gpio), S5P_GPIO_PULL_NONE);
> -
> -#ifdef CONFIG_SOUND_MAX98095
> -	/* Enable MAX98095 Codec */
> -	gpio_request(EXYNOS5_GPIO_X17, "max98095_enable");
> -	gpio_direction_output(EXYNOS5_GPIO_X17, 1);
> -	gpio_set_pull(EXYNOS5_GPIO_X17, S5P_GPIO_PULL_NONE);
> -#endif
> -}
> -
>  int exynos_init(void)
>  {
> -	board_enable_audio_codec();
> -
>  	return 0;
>  }
>  

Reviewed-by: Lukasz Majewski <lukma at denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181217/e628eed3/attachment.sig>