[U-Boot] [PATCH v4] pico-imx7d: Increase the CONFIG_ENV_OFFSET size

Stefano Babic sbabic at denx.de
Mon Dec 17 14:47:29 UTC 2018


On 17/12/18 15:13, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Fri, Nov 30, 2018 at 12:52 PM Fabio Estevam <festevam at gmail.com> wrote:
>>
>> U-Boot binary has grown in such a way that it goes beyond the reserved
>> area for the environment variables.
>>
>> Running "saveenv" causes U-Boot to hang because of this overlap.
>>
>> Fix this problem by increasing the CONFIG_ENV_OFFSET size.
>>
>> Also, in order to prevent this same problem in the future, use
>> CONFIG_BOARD_SIZE_LIMIT, which will detect the overlap in build-time.
>>
>> CONFIG_BOARD_SIZE_LIMIT does not accept math expressions, so declare
>> CONFIG_ENV_OFFSET with its direct value instead.
>>
>> Signed-off-by: Fabio Estevam <festevam at gmail.com>
>> ---
>> Changes since v3:
>> - Take the 69k u-boot.img offset into account when calculating
>> CONFIG_BOARD_SIZE_LIMIT (Wolfgang)
> 
> Could you please consider applying this version?
> 
> Wolfgang's patch causes breakage on some systems as reported by Tom
> and I would prefer we fix the critical problem soon independently of
> Wolgang's fix.

Yes, I agree with you - we could have a follow up patch when Wolfgang's
patch will be merged.

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list