[U-Boot] [PATCH v4 6/7] MSCC: add board support for the Luton based evaluation board

[Gregory CLEMENT]

Hi Daniel,
 
 On lun., déc. 17 2018, Daniel Schwierzeck <daniel.schwierzeck at gmail.com> wrote:

> Am 17.12.18 um 10:55 schrieb Gregory CLEMENT:
>> Hi Daniel,
>>  
>>  On dim., déc. 16 2018, Gregory CLEMENT <gregory.clement at bootlin.com> wrote:
>> 
>>> Hi Daniel,
>>>  
>>>  On sam., déc. 15 2018, Daniel Schwierzeck <daniel.schwierzeck at gmail.com> wrote:
>>>
>>>> Am 14.12.18 um 16:16 schrieb Gregory CLEMENT:
>>>>> Adding the support for the Luton boards PCB91 which share common code with
>>>>> the Ocelots boards, including board code, device tree and configuration.
>>>>>
>>>>> Signed-off-by: Gregory CLEMENT <gregory.clement at bootlin.com>
>>>>> ---
>>>>>  MAINTAINERS                    |  1 +
>>>>>  arch/mips/dts/luton_pcb091.dts | 36 ++++++++++++++
>>>>>  arch/mips/dts/mscc,luton.dtsi  | 87 ++++++++++++++++++++++++++++++++++
>>>>>  arch/mips/mach-mscc/Kconfig    |  2 +
>>>>>  board/mscc/luton/Kconfig       | 14 ++++++
>>>>>  board/mscc/luton/Makefile      |  3 ++
>>>>>  board/mscc/luton/luton.c       | 28 +++++++++++
>>>>>  configs/mscc_luton_defconfig   | 66 ++++++++++++++++++++++++++
>>>>>  8 files changed, 237 insertions(+)
>>>>>  create mode 100644 arch/mips/dts/luton_pcb091.dts
>>>>>  create mode 100644 arch/mips/dts/mscc,luton.dtsi
>>>>>  create mode 100644 board/mscc/luton/Kconfig
>>>>>  create mode 100644 board/mscc/luton/Makefile
>>>>>  create mode 100644 board/mscc/luton/luton.c
>>>>>  create mode 100644 configs/mscc_luton_defconfig
>>>>>
>>>>
>>>>> diff --git a/configs/mscc_luton_defconfig b/configs/mscc_luton_defconfig
>>>>> new file mode 100644
>>>>> index 0000000000..47fe12b6ee
>>>>> --- /dev/null
>>>>> +++ b/configs/mscc_luton_defconfig
>>>>> @@ -0,0 +1,66 @@
>>>>> +CONFIG_MIPS=y
>>>>> +CONFIG_SYS_TEXT_BASE=0x40000000
>>>>> +CONFIG_SYS_MALLOC_F_LEN=0x2000
>>>>> +CONFIG_DEBUG_UART_BOARD_INIT=y
>>>>> +CONFIG_DEBUG_UART_BASE=0x70100000
>>>>> +CONFIG_DEBUG_UART_CLOCK=208333333
>>>>> +CONFIG_ARCH_MSCC=y
>>>>> +CONFIG_TARGET_LUTON_PCB091=y
>>>>> +CONFIG_DDRTYPE_MT47H128M8HQ=y
>>>>> +CONFIG_SYS_LITTLE_ENDIAN=y
>>>>> +CONFIG_MIPS_BOOT_FDT=y
>>>>> +CONFIG_DEFAULT_DEVICE_TREE="luton_pcb091"
>>>>> +CONFIG_DEBUG_UART=y
>>>>> +CONFIG_FIT=y
>>>>> +CONFIG_BOOTDELAY=3
>>>>> +CONFIG_USE_BOOTARGS=y
>>>>> +CONFIG_BOOTARGS="console=ttyS0,115200"
>>>>> +CONFIG_LOGLEVEL=7
>>>>> +CONFIG_DISPLAY_CPUINFO=y
>>>>> +CONFIG_SYS_PROMPT="pcb091 # "
>>>>> +# CONFIG_CMD_BDI is not set
>>>>> +# CONFIG_CMD_CONSOLE is not set
>>>>> +# CONFIG_CMD_ELF is not set
>>>>> +# CONFIG_CMD_EXPORTENV is not set
>>>>> +# CONFIG_CMD_IMPORTENV is not set
>>>>> +# CONFIG_CMD_CRC32 is not set
>>>>> +CONFIG_CMD_MD5SUM=y
>>>>> +CONFIG_CMD_MEMINFO=y
>>>>> +CONFIG_CMD_MEMTEST=y
>>>>> +# CONFIG_CMD_FLASH is not set
>>>>> +CONFIG_CMD_GPIO=y
>>>>> +CONFIG_CMD_SF=y
>>>>> +CONFIG_CMD_SPI=y
>>>>> +CONFIG_CMD_DHCP=y
>>>>> +# CONFIG_NET_TFTP_VARS is not set
>>>>> +# CONFIG_CMD_NFS is not set
>>>>> +CONFIG_CMD_PING=y
>>>>> +CONFIG_CMD_MTDPARTS=y
>>>>> +CONFIG_MTDIDS_DEFAULT="nor0=spi_flash"
>>>>> +CONFIG_MTDPARTS_DEFAULT="mtdparts=spi_flash:512k(UBoot),256k(Env),256k(conf),6m at 1m(linux)"
>>>>> +# CONFIG_ISO_PARTITION is not set
>>>>> +CONFIG_OF_EMBED=y
>>>>
>>>> this gives now a build warning
>>>>
>>>> ===================== WARNING ======================
>>>> CONFIG_OF_EMBED is enabled. This option should only
>>>> be used for debugging purposes. Please use
>>>> CONFIG_OF_SEPARATE for boards in mainline.
>>>> See doc/README.fdt-control for more info.
>>>> ====================================================
>>>
>>> I did not get this warning. For now I base my series on v2018.11,
>>> should I base it on v2019.01-rc1 (i didn't realized it was already
>>> released) ?
>>>
>>>>
>>>>
>>>> Shall I change it when applying or do you want to test it first and send
>>>> a follow-up patch?
>>>
>>> I'd like to test it to be sure it continue to work.
>> 
>> I had a closer look on this issue and actually we have already a patch
>> series to apply which it is planned to be sent very soon. With this new
>> series we will be able to support multiple boards with this series
>> CONFIG_OF_SEPARATE will be used instead of CONFIG_OF_EMBED.
>> 
>> Would it be possible to keep this series as is ?
>> 
>
> I asked because I had to fix some minor merge conflicts when applying
> and I had to re-sync the defconfig files due to various changes in
> mainline. Thus I need to update your patches anyway and a simply
> removing CONFIG_OF_EMBED=y would be a trivial fix.
>
> You can review the current patch queue at u-boot-mips/microsemi which is
> based on u-boot-mips/next.

I tested you branch and it worked on both Ocelot and Luton. So I'm fine
with your changes.

Thanks !

Gregory

>
> -- 
> - Daniel

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com