[U-Boot] [PATCH 05/11] ethernet: MediaTek: add ethernet driver for MediaTek ARM-based SoCs

[Frank Wunderlich]

Hi,

nice to see ethernet-driver for bananapi r2 :)

but i have a problem while building:

drivers/net/mtk_eth.c: In function ‘mtk_eth_probe’:
drivers/net/mtk_eth.c:1014:3: warning: implicit declaration of function ‘noncached_alloc’; did you mean ‘kmem_cache_alloc’? [-Wimplicit-function-declaration]
   noncached_alloc(sizeof(struct pdma_txdesc) * NUM_TX_DESC,
   ^~~~~~~~~~~~~~~
   kmem_cache_alloc

searched for it:

./arch/arm/include/asm/system.h:571:phys_addr_t noncached_alloc(size_t size, size_t align);

and tried to fix by adding

#include <asm/system.h>

to drivers/net/mtk_eth.c, but still present. currently working on 2018-11, but 2019-01-rc2 seems to have no related change.

uploaded my staging here:

https://github.com/frank-w/u-boot/tree/bpi-r2_eth

any idea what i'm missing?

regards Frank

> Gesendet: Donnerstag, 20. Dezember 2018 um 09:12 Uhr
> Von: "Weijie Gao" <weijie.gao at mediatek.com>
> diff --git a/drivers/net/mtk_eth.c b/drivers/net/mtk_eth.c
> new file mode 100644
> index 00000000000..cc09404830a
> --- /dev/null
> +++ b/drivers/net/mtk_eth.c
...
> +	/* Prepare for tx/rx rings */
> +	priv->tx_ring_noc = (struct pdma_txdesc *)
> +		noncached_alloc(sizeof(struct pdma_txdesc) * NUM_TX_DESC,
> +				ARCH_DMA_MINALIGN);
> +	priv->rx_ring_noc = (struct pdma_rxdesc *)
> +		noncached_alloc(sizeof(struct pdma_rxdesc) * NUM_RX_DESC,
> +				ARCH_DMA_MINALIGN);