[U-Boot] [PATCH] imx: Add Makefile dependency for mkimage_fit_atf.sh

[Peng Fan]

Hi Cristopher,

> -----Original Message-----
> From: Christopher Spencer [mailto:Christopher.Spencer at sea.co.uk]
> Sent: 2018年12月20日 17:25
> To: 'u-boot at lists.denx.de' <u-boot at lists.denx.de>
> Cc: dl-uboot-imx <uboot-imx at nxp.com>
> Subject: [PATCH] imx: Add Makefile dependency for mkimage_fit_atf.sh
> 
> From: Chris Spencer <christopher.spencer at sea.co.uk>
> 
> The mkimage_fit_atf.sh SPL FIT generator script requires u-boot-nodtb.bin,
> but this was not enforced by the Makefile. This could cause the generator
> script to be executed before u-boot-nodtb.bin has been created.
> 
> Signed-off-by: Chris Spencer <christopher.spencer at sea.co.uk>
> Cc: NXP i.MX U-Boot Team <uboot-imx at nxp.com>
> ---
>  Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index fe41a5fe92..929f206f23 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1113,6 +1113,9 @@ U_BOOT_ITS = $(subst
> ",,$(CONFIG_SPL_FIT_SOURCE))  else  ifneq
> ($(CONFIG_SPL_FIT_GENERATOR),"")  U_BOOT_ITS := u-boot.its
> +ifeq
> +($(CONFIG_SPL_FIT_GENERATOR),"arch/arm/mach-imx/mkimage_fit_atf.sh
> ")
> +U_BOOT_ITS_DEPS += u-boot-nodtb.bin
> +endif

I did not meet this issue, my log as below, u-boot-nodtb.bin is generated before the mkimage_fit_atf.sh being executed,
  OBJCOPY spl/u-boot-spl-nodtb.bin
  COPY    spl/u-boot-spl.bin
  OBJCOPY u-boot-nodtb.bin
start=$(aarch64-poky-linux-nm u-boot | grep __rel_dyn_start | cut -f 1 -d ' '); end=$(aarch64-poky-linux-nm u-boot | grep __rel_dyn_end | cut -f 1 -d ' '); tools/relocate-rela u-boot-nodtb.bin 0x40200000 $start $end
./"arch/arm/mach-imx/mkimage_fit_atf.sh" \
arch/arm/dts/fsl-imx8mq-evk.dtb > u-boot.its
bl31.bin size:
28736
u-boot-nodtb.bin size:
429928
arch/arm/dts/fsl-imx8mq-evk.dtb size:
14737
  MKIMAGE u-boot.itb

Thanks,
Peng.

>  ifeq
> ($(CONFIG_SPL_FIT_GENERATOR),"arch/arm/mach-rockchip/make_fit_atf.py
> ")
>  U_BOOT_ITS_DEPS += u-boot
>  endif
> --
> 2.17.1
> 
> Disclaimer:
> 
> This email has been scanned for all known viruses by the MessageLabs Email
> Security System.
> 
> The contents of this email (including any attachments) are intended for the
> use of the mail addressee(s) shown, hence is private and in addition may
> include commercially sensitive information. If you are not the intended
> recipient of this email any disclosure, copying, distribution or use of its
> contents is strictly prohibited. You should notify the sender immediately and
> then delete it (including any attachments) from your system.
> 
> The information contained in or attached to this message may also be subject
> to the export control laws and regulations of the United Kingdom and the
> United States. This specifically includes, but is not limited to, the Arms Export
> Control Act (22 U.S.C. 2751-2794) and the International Traffic in Arms
> Regulation (22 C.F.R 120-130) as well as the Export Administration Act (50
> U.S.C. App. 2401-2420), the Export Administration Regulation (15 C.F.R.
> 730-774) and the UK Export Control Act 2002.
> 
> Please help out the environment by only printing this e-mail if absolutely
> necessary - Thank you.
> 
> SEA is the brand name of Systems Engineering & Assessment Ltd (registered
> office: Beckington Castle, 17 Castle Corner, Beckington, Frome, Somerset,
> BA11 6TA, UK - company number 02302168).